Toilville/oplsdt
Watch
5
0
Fork
You've already forked oplsdt
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ci: bring codebox node 22 fix to main #13

Merged
peterswimm merged 3 commits from chore/sync-codebox-fix into main 2026-10-04 22:47:20 +00:00
Conversation 0 Commits 3 Files changed 2 +2 -2
peterswimm commented 2026-10-04 22:36:31 +00:00
Owner
Copy link

Scope

Bring the codebox CI fix (peterswimm/oplsdt-stock-runner #2, c9f254b) into main; #12 merged just before it. node --test tools/codebox-harness/ fails on node 22 (the lane's image) with Cannot find module; both ci.yml and the npm test script now use the quoted glob 'tools/codebox-harness/*.test.mjs'.

Testing

  • node:22-bookworm-slim: old command fails (control), new command 52/52 pass.
  • Local node 26 npm test: 52/52.
  • Merge of stock-rnbo-runner into main is clean; diff is these 2 lines.

Impact Statement

  • Existing features: none.
  • Public APIs / contracts: none.
  • Schemas: none.
  • Data / artifacts: none.
  • Integrations: codebox CI lane should go green on main.
  • Mappings: none.
  • Backward compatibility: test files must keep the *.test.mjs suffix (all do).

Docs

None needed.

## Scope Bring the codebox CI fix (peterswimm/oplsdt-stock-runner #2, c9f254b) into main; #12 merged just before it. `node --test tools/codebox-harness/` fails on node 22 (the lane's image) with `Cannot find module`; both `ci.yml` and the `npm test` script now use the quoted glob `'tools/codebox-harness/*.test.mjs'`. ## Testing - node:22-bookworm-slim: old command fails (control), new command 52/52 pass. - Local node 26 `npm test`: 52/52. - Merge of stock-rnbo-runner into main is clean; diff is these 2 lines. ## Impact Statement - Existing features: none. - Public APIs / contracts: none. - Schemas: none. - Data / artifacts: none. - Integrations: codebox CI lane should go green on main. - Mappings: none. - Backward compatibility: test files must keep the `*.test.mjs` suffix (all do). ## Docs None needed. 
node 22 treats 'node --test <dir>' as a module path and fails with
'Cannot find module tools/codebox-harness'; node >=23 expands it. The
codebox lane runs node:22 and has failed this way since the harness was
added. A quoted glob works on both.
Reviewed-on: peterswimm/oplsdt-stock-runner#2
Merge stock-rnbo-runner (codebox CI fix) into main
All checks were successful
PR policy check / policy-gate (pull_request) Successful in 0s
Details
ci / codebox (pull_request) Successful in 7s
Details
ci / max-lint (pull_request) Successful in 24s
Details
ci / compiler (pull_request) Successful in 27s
Details
9c05770d50
peterswimm deleted branch chore/sync-codebox-fix 2026-10-04 22:47:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Toilville/oplsdt!13
No description provided.