peterswimm/oplsdt-stock-runner
Watch
1
0
Fork
You've already forked oplsdt-stock-runner
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ci: glob codebox tests so node 22 finds them #2

Merged
peterswimm merged 1 commit from fix/codebox-ci-node22 into stock-rnbo-runner 2026-10-04 22:32:22 +00:00
Conversation 0 Commits 1 Files changed 2 +2 -2
peterswimm commented 2026-10-04 22:25:47 +00:00
Owner
Copy link

Scope

Fix the codebox CI lane, red since tools/codebox-harness was added (6b03d51). node --test tools/codebox-harness/ on node 22 (the lane's node:22-bookworm-slim image) resolves the directory as a module: Error: Cannot find module '.../tools/codebox-harness', 1 test, 1 fail. Node >=23 expands the directory, so it passed locally. Both ci.yml and the npm test script now use a quoted glob, 'tools/codebox-harness/*.test.mjs'.

Testing

  • node:22-bookworm-slim (docker), old command: fails with the error above (the control).
  • node:22-bookworm-slim, new command: 52/52 pass.
  • Local node 26, npm test: 52/52 pass.

Impact Statement

  • Existing features: none.
  • Public APIs / contracts: none.
  • Schemas: none.
  • Data / artifacts: none.
  • Integrations: CI codebox lane should go green; npm test unchanged in result.
  • Mappings: none.
  • Backward compatibility: test files must keep the *.test.mjs suffix to be picked up (all current ones do).

Docs

None needed.

## Scope Fix the `codebox` CI lane, red since `tools/codebox-harness` was added (6b03d51). `node --test tools/codebox-harness/` on node 22 (the lane's `node:22-bookworm-slim` image) resolves the directory as a module: `Error: Cannot find module '.../tools/codebox-harness'`, 1 test, 1 fail. Node >=23 expands the directory, so it passed locally. Both `ci.yml` and the `npm test` script now use a quoted glob, `'tools/codebox-harness/*.test.mjs'`. ## Testing - node:22-bookworm-slim (docker), old command: fails with the error above (the control). - node:22-bookworm-slim, new command: 52/52 pass. - Local node 26, `npm test`: 52/52 pass. ## Impact Statement - Existing features: none. - Public APIs / contracts: none. - Schemas: none. - Data / artifacts: none. - Integrations: CI codebox lane should go green; `npm test` unchanged in result. - Mappings: none. - Backward compatibility: test files must keep the `*.test.mjs` suffix to be picked up (all current ones do). ## Docs None needed.
ci: glob codebox tests so node 22 finds them
Some checks are pending
ci / compiler (pull_request) Waiting to run
Details
ci / max-lint (pull_request) Waiting to run
Details
ci / codebox (pull_request) Waiting to run
Details
c9f254b17e 
node 22 treats 'node --test <dir>' as a module path and fails with
'Cannot find module tools/codebox-harness'; node >=23 expands it. The
codebox lane runs node:22 and has failed this way since the harness was
added. A quoted glob works on both.
peterswimm merged commit bdbaa04aad into stock-rnbo-runner 2026-10-04 22:32:22 +00:00
peterswimm deleted branch fix/codebox-ci-node22 2026-10-04 22:32:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
peterswimm/oplsdt-stock-runner!2
No description provided.