docs(spelwork): Part 2 token status after #225 and #226 #227

Merged
peterswimm merged 1 commit from docs/part2-token-status into main 2026-10-23 21:25:02 +00:00
Member

Refs #171. Does not close it.

Scope

A documentation cleanup of Brand/specs/spelwork/spelwork-dashboard-design-part2.md after #225 (severity and stale tokens) and #226 (step ramp) merged. It changes only the statements those PRs made stale. The dashboard design decisions, the three figures and every unrelated dependency row are unchanged.

  • An "Updated 2026-10-23" line, and a note that the figures and the review annotations inside them predate #225 and #226.
  • Decisions 1, 2 and 7: the tokens now exist (color.accent.critical, color.neutral.warm-stale, the baseline dark values, color.stage.0 to .5). The lightness order holds in the dark theme only; the light theme is a known issue in Part 1 §3.
  • §1.3 and the §2.3 "step ramp colours" row: the sketches were drawn before the tokens existed, so they use no severity or step colour.
  • §5 items 1 and 4 marked resolved. Item 11 and the closing sentence say SPELWork still has no dark theme and emits no accent.* or dark stage values.

Not in this PR: the three PNG figures, Part 1, any token or generator change.

Testing

Documentation only, so no behaviour tests apply. The 13 check commands and python3 -m pytest generator/tests/ were run anyway: all pass (400 passed, 20 skipped). No dist/ file changes. A search finds none of the old phrases ("not yet written", "do not exist yet", "still to be drafted", "not drafted", "(new)") left in the file.

Impact Statement

  • Existing features: none.
  • Public APIs / contracts: none.
  • Schemas: none.
  • Data / artifacts: none. The figures are not redrawn.
  • Integrations: none.
  • Mappings: none.
  • Backward compatibility: no impact.

Docs

This PR is the docs update.

Remaining review points

  1. The three figures keep stale text inside the PNGs. worker-health.png says the tokens are "not drafted" or "to be drafted". task-in-progress.png says "its tokens are not drafted". The sources are HTML files outside this repo (icon-flatten-export/delivery/171-worker-health/). Redrawing is out of scope. The spec says the annotations predate #225 and #226.
  2. The sketches still use no severity or step colour. They have not been redrawn with the tokens.
  3. SPELWork does not receive the severity tokens, and it has no dark stage values. The delivery question stays open in §5 items 1 and 11.
Refs #171. Does not close it. ## Scope A documentation cleanup of `Brand/specs/spelwork/spelwork-dashboard-design-part2.md` after #225 (severity and stale tokens) and #226 (step ramp) merged. It changes only the statements those PRs made stale. The dashboard design decisions, the three figures and every unrelated dependency row are unchanged. - An "Updated 2026-10-23" line, and a note that the figures and the review annotations inside them predate #225 and #226. - Decisions 1, 2 and 7: the tokens now exist (`color.accent.critical`, `color.neutral.warm-stale`, the baseline dark values, `color.stage.0` to `.5`). The lightness order holds in the dark theme only; the light theme is a known issue in Part 1 §3. - §1.3 and the §2.3 "step ramp colours" row: the sketches were drawn before the tokens existed, so they use no severity or step colour. - §5 items 1 and 4 marked resolved. Item 11 and the closing sentence say SPELWork still has no dark theme and emits no `accent.*` or dark stage values. Not in this PR: the three PNG figures, Part 1, any token or generator change. ## Testing Documentation only, so no behaviour tests apply. The 13 check commands and `python3 -m pytest generator/tests/` were run anyway: all pass (400 passed, 20 skipped). No `dist/` file changes. A search finds none of the old phrases ("not yet written", "do not exist yet", "still to be drafted", "not drafted", "(new)") left in the file. ## Impact Statement - Existing features: none. - Public APIs / contracts: none. - Schemas: none. - Data / artifacts: none. The figures are not redrawn. - Integrations: none. - Mappings: none. - Backward compatibility: no impact. ## Docs This PR is the docs update. ## Remaining review points 1. **The three figures keep stale text inside the PNGs.** `worker-health.png` says the tokens are "not drafted" or "to be drafted". `task-in-progress.png` says "its tokens are not drafted". The sources are HTML files outside this repo (`icon-flatten-export/delivery/171-worker-health/`). Redrawing is out of scope. The spec says the annotations predate #225 and #226. 2. **The sketches still use no severity or step colour.** They have not been redrawn with the tokens. 3. **SPELWork does not receive the severity tokens, and it has no dark stage values.** The delivery question stays open in §5 items 1 and 11.
docs(spelwork): Part 2 token status after #225 and #226
All checks were successful
PR policy check / policy-gate (pull_request) Successful in 1s
Security Scans / Trivy filesystem scan (pull_request) Successful in 57s
Block Validation / validate (pull_request) Successful in 1m21s
Security Scans / Gitleaks secret scan (pull_request) Successful in 47s
Test Generator / lint-workflows (pull_request) Successful in 32s
Test Generator / test (pull_request) Successful in 1m19s
Test Generator / lint-prose (pull_request) Successful in 35s
UDG dist drift gate / dist/ matches dtcg + udg sources (pull_request) Successful in 22s
Copy coverage / Design copy reaching rendered HTML (pull_request) Successful in 47s
cefe7c6b71
Part 2 still said the severity tokens and the step ramp were not drafted.
Both are merged: color.accent.critical, color.neutral.warm-stale and the
baseline dark values in #225, color.stage.0 to .5 in #226.

Update only the statements those PRs make stale:
- an updated-on line and an explicit note that the figures, and the
  review annotations inside them, predate #225 and #226 and are unchanged
- decisions 1, 2 and 7: tokens now exist; the lightness order holds in the
  dark theme only (Part 1 section 3, Known issue)
- section 1.3 and the section 2.3 "step ramp colours" row: the sketches
  were drawn before the tokens existed and use no severity or step colour
- section 5 items 1 and 4 marked resolved; item 11 and the closing sentence
  say SPELWork still has no dark theme and emits no accent.* or dark stage
  values

The design decisions, the three figures and every other dependency row are
unchanged.
peterswimm deleted branch docs/part2-token-status 2026-10-23 21:25:02 +00:00
Sign in to join this conversation.
No description provided.