feat(icon-registry): add spelwork-pua asset status for shipped house-style art #163

Merged

peterswimm merged 2 commits from fix/icon-registry-spelwork-pua-160 into main 2026-09-25 15:18:21 +00:00

Conversation 0 Commits 2 Files changed 8 +111 -101

ville commented 2026-09-24 10:30:29 +00:00

Member

Copy link

Closes #160.

assetStatus could only say "openmoji" or "pending-pua", so the registry
had no way to mark the 45 delivered house-style icons as shipped. This adds
"spelwork-pua" and moves every token except spel.tribunal.pragmatic (the
one token with no art) onto it.

What changed

• types.ts — third assetStatus value: "spelwork-pua".
• registry.ts — 45 of 46 tokens moved to "spelwork-pua";
  spel.tribunal.pragmatic corrected from "openmoji" (it was reusing
  spel.tribunal.frame-invariant's glyph, not really an OpenMoji choice) to
  "pending-pua". Attribution updated to "SPELWork Icon Registry" for the
  tokens moving off OpenMoji, so attribution.ts's compliance report sorts
  them correctly.
• resolve.ts — isPlaceholder now trusts assetStatus alone; dropped the
  isPlaceholderGlyph hex-string heuristic, which would have kept the 4 seed
  PUA tokens (spel.guise, spel.bastia, spel.lineage, spel.drift)
  flagged as placeholders after their status moved, since they store
  defaultGlyph as a literal hex string (e.g. "E901").
• registry.test.ts, resolve.test.ts — updated expectations.
  resolve.test.ts's "returns placeholder for pending-pua tokens" test moves
  its subject from spel.guise (now shipped) to spel.tribunal.pragmatic.
• artifact.py, README.md — kept in sync with the same status values.

Deferred, not in this PR: defaultGlyph's two encodings (hex string vs.
literal character) — normalising that touches every reader of the field and
this PR removes the only place that needed it fixed. Separate issue.

Not in this PR

• The 45 SVG assets themselves — this only changes how the registry records
  status, not what renders. Delivery is a separate step.
• artifact.py's icon-card badges and the "0 final custom glyphs — all
  pending design" stats caption (~line 2331–2378) still assume only
  "openmoji"/"pending-pua" exist, so the generated design-tool page will
  now show a stale caption. Flagging, not fixing here — didn't want to make
  a presentation call that isn't mine to make.
• examples.ts still uses spel.guise as its "pending-pua" demo, same
  problem resolve.test.ts had. Same reasoning: flagging rather than
  changing a file the decision comment didn't scope in.

Test status

Could not run vitest — this checkout has no Node.js installed. Changes were
reviewed by hand against every current caller of assetStatus (grep -rn
across src/); reasoning for each file is above.

Closes #160. `assetStatus` could only say `"openmoji"` or `"pending-pua"`, so the registry had no way to mark the 45 delivered house-style icons as shipped. This adds `"spelwork-pua"` and moves every token except `spel.tribunal.pragmatic` (the one token with no art) onto it. ## What changed - `types.ts` — third `assetStatus` value: `"spelwork-pua"`. - `registry.ts` — 45 of 46 tokens moved to `"spelwork-pua"`; `spel.tribunal.pragmatic` corrected from `"openmoji"` (it was reusing `spel.tribunal.frame-invariant`'s glyph, not really an OpenMoji choice) to `"pending-pua"`. Attribution updated to `"SPELWork Icon Registry"` for the tokens moving off OpenMoji, so `attribution.ts`'s compliance report sorts them correctly. - `resolve.ts` — `isPlaceholder` now trusts `assetStatus` alone; dropped the `isPlaceholderGlyph` hex-string heuristic, which would have kept the 4 seed PUA tokens (`spel.guise`, `spel.bastia`, `spel.lineage`, `spel.drift`) flagged as placeholders after their status moved, since they store `defaultGlyph` as a literal hex string (e.g. `"E901"`). - `registry.test.ts`, `resolve.test.ts` — updated expectations. `resolve.test.ts`'s "returns placeholder for pending-pua tokens" test moves its subject from `spel.guise` (now shipped) to `spel.tribunal.pragmatic`. - `artifact.py`, `README.md` — kept in sync with the same status values. **Deferred, not in this PR:** `defaultGlyph`'s two encodings (hex string vs. literal character) — normalising that touches every reader of the field and this PR removes the only place that needed it fixed. Separate issue. ## Not in this PR - The 45 SVG assets themselves — this only changes how the registry records status, not what renders. Delivery is a separate step. - `artifact.py`'s icon-card badges and the "0 final custom glyphs — all pending design" stats caption (~line 2331–2378) still assume only `"openmoji"`/`"pending-pua"` exist, so the generated design-tool page will now show a stale caption. Flagging, not fixing here — didn't want to make a presentation call that isn't mine to make. - `examples.ts` still uses `spel.guise` as its "pending-pua" demo, same problem `resolve.test.ts` had. Same reasoning: flagging rather than changing a file the decision comment didn't scope in. ## Test status Could not run `vitest` — this checkout has no Node.js installed. Changes were reviewed by hand against every current caller of `assetStatus` (`grep -rn` across `src/`); reasoning for each file is above.

ville added 1 commit 2026-09-24 10:30:29 +00:00

feat(icon-registry): add spelwork-pua asset status for shipped house-style art ... ccf77e3090

Closes #160. `assetStatus` could only say "openmoji" or "pending-pua", so the
registry had no way to mark the 45 delivered house-style icons as shipped.

- types.ts: add "spelwork-pua" to the assetStatus union
- registry.ts: move all seed/stage/dimension tokens to "spelwork-pua" except
  spel.tribunal.pragmatic (the one token with no art, now "pending-pua"
  instead of incorrectly "openmoji")
- resolve.ts: trust assetStatus for isPlaceholder, drop the isPlaceholderGlyph
  hex-string heuristic (it would keep the 4 seed PUA tokens flagged as
  placeholders after their status moves, since they store defaultGlyph as a
  literal hex string)
- registry.test.ts, resolve.test.ts: updated expectations; resolve.test.ts's
  pending-pua example moves from spel.guise (now shipped) to
  spel.tribunal.pragmatic
- artifact.py, README.md: kept in sync with the same status values

ville referenced this pull request 2026-09-24 10:33:03 +00:00

icon-registry: add an assetStatus value for shipped house-style art #160

ville added 1 commit 2026-09-24 10:35:26 +00:00

test(icon-registry): fix attribution tests broken by the spelwork-pua move ... b2e01c39f9

vitest wasn't runnable in the environment that authored the previous commit
(no Node.js). Installed Node and ran the suite: 6 failures in
attribution.test.ts, all from the same cause — moving spel.consent,
spel.plurality et al. off "openmoji" attribution left zero reserved tokens
attributed to OpenMoji, so tests asserting an OpenMoji source among resolved
reserved tokens had nothing to find.

Fixed by testing the OpenMoji attribution path through a theme-defined
custom icon instead of a reserved token, since the attribution.ts logic
being tested (getAttributions/renderCredits*/getComplianceReport) works on
any resolved icon's attribution string, not specifically on reserved-token
data. 40/40 tests passing.

peterswimm merged commit c55ee450a8 into main 2026-09-25 15:18:21 +00:00

peterswimm deleted branch fix/icon-registry-spelwork-pua-160 2026-09-25 15:18:21 +00:00

peterswimm referenced this pull request from a commit 2026-09-25 15:18:22 +00:00

Merge pull request 'feat(icon-registry): add spelwork-pua asset status for shipped house-style art' (#163) from fix/icon-registry-spelwork-pua-160 into main

peterswimm referenced this pull request from a commit 2026-10-07 22:54:24 +00:00

fix(dist): rebuild artifact.html left stale by #163

peterswimm referenced this pull request 2026-10-07 22:54:30 +00:00

fix(dist): rebuild artifact.html left stale by #163 #192

peterswimm referenced this pull request from a commit 2026-10-07 22:55:21 +00:00

Merge pull request 'fix(dist): rebuild artifact.html left stale by #163' (#192) from fix/rebuild-stale-artifact-html into main

peterswimm referenced this pull request from a commit 2026-10-07 22:58:27 +00:00

ci(udg): build bot — add the build-dist label and CI runs `just build`

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

build-dist

Ask the UDG build bot to run just build and commit generated files to this PR

  

priority

P1

Urgent — no working icon yet (custom art pending) or a shipping asset

  

priority

P2

High — has an accessible stand-in; bespoke art wanted

  

priority

P3

Medium — stage visual headers

  

priority

P4

Low — behavioral dimension family

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

build-dist

priority

P1

priority

P2

priority

P3

priority

P4

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Toilville/toilville-design!163

No description provided.