fix(ci): stop the MLX job's PATH step failing on Apple Silicon #11

Merged

peterswimm merged 1 commit from fix/mlx-ci-path-step-exit-status into main

2026-10-10 21:28:45 +00:00

peterswimm commented

2026-10-10 21:22:23 +00:00

Owner

Summary

The MLX CI job has failed within seconds on every run back to at least run #19, so CI has never built the mlx feature in that time, and that includes #10. Same bug as toilville_rituals#477.

The "Ensure cargo + brew on PATH" brace group exits with the status of its last line, [[ -x /usr/local/bin/brew ]] && .... Intel-layout brew is absent on Apple Silicon, so the group exits 1. Every line writes to $GITHUB_PATH, so the step prints nothing: the log shows RUN exit status 1 right after checkout (run #24, task 111504).

Scope

.forgejo/workflows/ci.yml only:

Add a trailing true to the PATH brace group, with a comment saying why.
Remove the GIT_SSH_COMMAND / known_hosts step. mlx-rs comes from public HTTPS since #10, so it has nothing left to do.
Reword the core job's CARGO_NET_GIT_FETCH_WITH_CLI comment, which described an HTTPS rewrite that #10 removed.

Testing

Reproduced locally on Apple Silicon: { [[ -f /nonexistent ]] && echo x; } >/dev/null exits 1; with a trailing true it exits 0. /usr/local/bin/brew is absent here.
This PR's own MLX run is the real test, since it will be the first time CI gets past the PATH step. If clippy or the tests then fail, that's a pre-existing problem the bug was hiding.

Docs

None.

Impact Statement

CI only. The MLX job gets past its PATH step and actually builds the mlx feature, which may surface failures that were masked until now. No crate code changes. Also, the FORGE_CI_HTTPS_TOKEN repo secret was deleted on 2026-10-10; nothing on main referenced it.

## Summary The MLX CI job has failed within seconds on every run back to at least run #19, so CI has never built the `mlx` feature in that time, and that includes #10. Same bug as toilville_rituals#477. The "Ensure cargo + brew on PATH" brace group exits with the status of its last line, `[[ -x /usr/local/bin/brew ]] && ...`. Intel-layout brew is absent on Apple Silicon, so the group exits 1. Every line writes to `$GITHUB_PATH`, so the step prints nothing: the log shows `RUN exit status 1` right after checkout (run #24, task 111504). ## Scope `.forgejo/workflows/ci.yml` only: - Add a trailing `true` to the PATH brace group, with a comment saying why. - Remove the `GIT_SSH_COMMAND` / known_hosts step. mlx-rs comes from public HTTPS since #10, so it has nothing left to do. - Reword the core job's `CARGO_NET_GIT_FETCH_WITH_CLI` comment, which described an HTTPS rewrite that #10 removed. ## Testing - Reproduced locally on Apple Silicon: `{ [[ -f /nonexistent ]] && echo x; } >/dev/null` exits 1; with a trailing `true` it exits 0. `/usr/local/bin/brew` is absent here. - This PR's own MLX run is the real test, since it will be the first time CI gets past the PATH step. If clippy or the tests then fail, that's a pre-existing problem the bug was hiding. ## Docs None. ## Impact Statement CI only. The MLX job gets past its PATH step and actually builds the `mlx` feature, which may surface failures that were masked until now. No crate code changes. Also, the `FORGE_CI_HTTPS_TOKEN` repo secret was deleted on 2026-10-10; nothing on main referenced it.

peterswimm added 1 commit

2026-10-10 21:22:23 +00:00

fix(ci): stop the MLX job's PATH step failing on Apple Silicon

CI / MLX feature (macOS + Apple Silicon) (pull_request) Waiting to run

Details

CI / lint-workflows (pull_request) Successful in 16s

Details

PR policy check / policy-gate (pull_request) Successful in 0s

Details

CI / Core (default features, no MLX) (pull_request) Successful in 58s

Details

84bfe4d014

The 'Ensure cargo + brew on PATH' brace group exits with its last
command's status, a test for Intel-layout brew at /usr/local/bin. That is
absent on Apple Silicon, so the group exits 1, and because every line
writes to $GITHUB_PATH the step fails with no output: 'RUN exit status 1'
right after checkout. The MLX job has failed within seconds on every run since at least #19, so
the mlx feature has not been built in CI in that time. Same bug as toilville_rituals#477.

Also drop the GIT_SSH_COMMAND step and the comment about an HTTPS rewrite:
the mlx-rs mirror is public HTTPS since #10, so neither has anything left
to do.

peterswimm merged commit 90339bc403 into main

2026-10-10 21:28:45 +00:00

peterswimm deleted branch fix/mlx-ci-path-step-exit-status

2026-10-10 21:28:45 +00:00

peterswimm referenced this pull request from a commit

2026-10-10 21:28:46 +00:00

Merge pull request 'fix(ci): stop the MLX job's PATH step failing on Apple Silicon' (#11) from fix/mlx-ci-path-step-exit-status into main